perf: Only load key dimension and measure values during chart initialization #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bprusinowski
force-pushed
the
perf/do-not-fetch-non-key-dimensions
branch
from
dd0e32c to
19c2267
Compare
bprusinowski
force-pushed
the
perf/do-not-fetch-non-key-dimensions
branch
from
9bb172c to
b6b3b22
Compare
bprusinowski
added a commit
that referenced
this pull request
Nov 19, 2024
...as the DataCubePreview will be re-used in #1890
bprusinowski
added a commit
that referenced
this pull request
Nov 20, 2024
...as the DataCubePreview will be re-used in #1890
…into perf/do-not-fetch-non-key-dimensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1658
This PR optimizes performance of initializing charts based on cubes with non-key dimensions by limiting these dimensions and measures selection to only include key dimensions.
We do it by re-using
DataCubePreviewquery, which in most of the cases is loaded and cached before starting a new chart that loads components metadata, so we know which dimension is a key dimension.